Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tag-tiddler to tag-pill drag & drop import, add hidden setting for TagPillDragFilter #8182

Merged
merged 4 commits into from
Jul 28, 2024

Conversation

pmario
Copy link
Member

@pmario pmario commented May 8, 2024

This PR fixes: #8181

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tiddlywiki5 ✅ Ready (Inspect) Visit Preview May 8, 2024 10:40am

@pmario
Copy link
Member Author

pmario commented Jul 28, 2024

@Jermolene -- bump

@Jermolene
Copy link
Member

Hi @pmario as I mentioned here, on balance I think that we should not change the default behaviour.

@pmario
Copy link
Member Author

pmario commented Jul 28, 2024

@Jermolene -- I did change the default, so it dos not include the tag tiddler itself. Also updated the docs.

@Jermolene
Copy link
Member

Thanks @pmario

By the way, it might be useful to make a plugin that contains a UI for the hidden settings. The motivation for keeping these settings hidden is generally to avoid bloating the core with the relevant language strings, so putting the UI in a plugin would be reasonable.

@Jermolene Jermolene merged commit e80c997 into TiddlyWiki:master Jul 28, 2024
3 checks passed
@pmario pmario deleted the fix-8181-tag-pill-import branch July 30, 2024 08:07
tsukasa-au pushed a commit to tsukasa-au/TiddlyWiki5 that referenced this pull request Aug 3, 2024
…r TagPillDragFilter (TiddlyWiki#8182)

* add tag-tiddler to tag-pill drag & drop import, add hidden setting for TagPillDragFilter

* update docs to make Be Aware clearer

* exclude the tag tiddler and update hidden docs accordingly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag-pill import (drag and drop) should include the tiddler at tag's home node, if it exists
2 participants